Fix Wings of Entropy not working with Swordstorm and other Dual Wield or One Handed Axe Skills#9317
Open
Peechey wants to merge 10 commits intoPathOfBuildingCommunity:devfrom
Open
Conversation
LocalIdentity
approved these changes
Nov 22, 2025
LocalIdentity
requested changes
Nov 22, 2025
Contributor
LocalIdentity
left a comment
LocalIdentity
left a comment
There was a problem hiding this comment.
Currently breaks tests
Peechey
force-pushed
the
fix/wings-of-entropy-skill-interactions
branch
from
5b56dd9 to
8217546
Compare
Peechey
added
bug: behaviour
…mo, Swordstorm Fix Wings working with Laacerate of Butchery when it shouldn't, keep Ice Crash of Cadence working even with its weird 2H weaponTypes
Peechey
force-pushed
the
fix/wings-of-entropy-skill-interactions
branch
from
8217546 to
68013a3
Compare
but also a fix to not allow GS of Earthshaking
Peechey
force-pushed
the
fix/wings-of-entropy-skill-interactions
branch
from
f020028 to
51d863c
Compare
Peechey
force-pushed
the
fix/wings-of-entropy-skill-interactions
branch
from
cdce645 to
5373112
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8031
Description of the problem being solved:
Fixes Wings of Entropy and its Replica disabling dual wield and one handed axe skills like Swordstorm, Lacerate of Haemorrhage, and Chain Hook. This also fixes Wings allowing Lacerate of Butchering, which requires a Two Handed Axe or Sword. The dual wielding mod for Wings overwrites the Two Handed Axe match for Butchering, tested in game. Ice Crash of Cadence does work with Wings in game and has some odd weaponTypes so a little extra code was needed to differentiate for Butchering vs Cadence.
Tested against a number of skills, including skills that should not have been affected and a few other weapon combinations like Dual Strike of Ambidexterity. The logic changed for weaponFlags is exclusive to "Counts as Dual Wielding" items so any other skill/weapon combination should be unchanged.
Tested does work in-game with Wings:
Lacerate of Hemm
Sunder
Chain Hook
Ice Crash of Cadence
Earthshatter
Tested does NOT work in-game:
Lacerate of Butchering
Dual Strike of Ambi
Ground Slam of Earthshaking
...
Reave
Holy Sweep
Link to a build that showcases this PR:
Before screenshot:
After screenshot: