Skip to content

Allows you to see all boxes when viewing many jewel sockets#527

Merged
LocalIdentity merged 12 commits intoPathOfBuildingCommunity:devfrom
Wires77:issue-115
Jul 15, 2020
Merged

Allows you to see all boxes when viewing many jewel sockets#527
LocalIdentity merged 12 commits intoPathOfBuildingCommunity:devfrom
Wires77:issue-115

Conversation

@Wires77
Copy link
Copy Markdown
Member

@Wires77 Wires77 commented Mar 11, 2020

Fixes #115
Closes #325 since I deleted the old fork

@ppoelzl ppoelzl added the enhancement New feature, calculation, or mod label Mar 21, 2020
@LocalIdentity LocalIdentity linked an issue Mar 22, 2020 that may be closed by this pull request
Jewel Tooltips Too Tall #115
Closed
@Wires77
Copy link
Copy Markdown
Member Author

Wires77 commented Apr 20, 2020

Any issues with this PR?

@Wires77
Copy link
Copy Markdown
Member Author

Wires77 commented Jun 29, 2020

This is ready to merge again

@Wires77
Copy link
Copy Markdown
Member Author

Wires77 commented Jun 29, 2020 •
edited
Loading

Build code to test with:

https://pastebin.com/WfqKPBNs

@LocalIdentity
Copy link
Copy Markdown
Contributor

LocalIdentity commented Jun 30, 2020

Had a bit more of a look and with a build like this https://pastebin.com/5aghh31T (Herald stacker from last league) the tooltips can get very large. Noticed that PoB still shows the very long vertical scroll bar for the tooltip as if it was still using the current vertical tooltip box and is not adding a horizontal scroll bar like it should. If these 2 issues are sorted out then it seems like the PR would be ready to merge

@Wires77
Copy link
Copy Markdown
Member Author

Wires77 commented Jun 30, 2020

Fixed the immediate scrollbar issue, though the code isn't as nice as I'd like. Plus while debugging I noticed the bottom border of a tooltip gets cut off. It's too late here to make my brain do that math properly to find the error, so I may commit a bit more to it tomorrow.

@Wires77
Copy link
Copy Markdown
Member Author

Wires77 commented Jul 6, 2020

This is ready for approval/merge again

@LocalIdentity LocalIdentity merged commit 21ae3e2 into PathOfBuildingCommunity:dev Jul 15, 2020
@Wires77 Wires77 deleted the issue-115 branch November 17, 2020 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LocalIdentity LocalIdentity LocalIdentity approved these changes

Assignees

No one assigned

Labels

enhancement New feature, calculation, or mod

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Jewel Tooltips Too Tall

3 participants

@Wires77 @LocalIdentity @ppoelzl