Skip unused cluster calculations in Offence/Defence mode - #10373
Open
AdamZ-8113 wants to merge 1 commit into
Open
AdamZ-8113 wants to merge 1 commit into
AdamZ-8113 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
When calculating node power in Offence/Defence mode, PoB also checks cluster passives for the power report even though it doesn't use those results.
This is because Offence/Defence is a combined scoring mode with no single stat selected, but the cluster-report loop only stores a result when a single stat is selected.
The current process does this check to after the calculation has already run. This PR moves the check ahead of the cluster calculations and excludes the skipped work from the progress total.
Existing cluster power values are still cleared when switching modes, and single-stat modes such as Hit DPS retain their calculations.
Steps taken to verify a working solution:
Link to a build that showcases this PR: