Cache unique database stat sort values - #10372
Open
AdamZ-8113 wants to merge 1 commit into
Open
AdamZ-8113 wants to merge 1 commit into
AdamZ-8113 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Sorting the unique item database by a calculated stat runs a calculation for every valid item and equipment slot. There is no caching currently, so rebuilding that same sorted list, including after changing its search filter (i.e. while typing or toggling item slots), currently repeats every calculation even when the build output hasn't changed.
This caches each unique item's calculated sort value until the build changes. Values are kept separately for each stat and item set, so repeated sorts and filter changes can reuse them without changing the initial calculation or its result.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Before screenshot:
After screenshot: