Skip hidden slots when sorting item database by stats - #10371
Open
AdamZ-8113 wants to merge 1 commit into
Open
AdamZ-8113 wants to merge 1 commit into
AdamZ-8113 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Sorting correctness + performance in the item database, mostly for Rings.
Item database stat sorting could compare items against hidden equipment slots. For hidden slots ignored by the calculation engine, the comparison returned the build’s unchanged stats instead of a meaningful item replacement result.
ListBuilderkeeps the highest comparison value usingm_max, so these unchanged results could distort item sorting. For example, rings that reduced DPS could tie at the build’s current DPS and sort alphabetically instead of by their actual results.This adds
slot.shown()to the existing slot eligibility checks, matching item hover comparisons. Sorting now calculates comparisons only for visible, active slots in the selected item set. This effectively stopsRing 3from being included in the sorting, unless the Nameless Bloodline node "The Unseen Hand" is allocated.Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://pob.codes/b/59K4qqNsBb_Before screenshot:
The Will of TulAfter screenshot: