Skip to content

Add support for adding vestigial implicits #10156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vaisest wants to merge 12 commits into
base: dev
Choose a base branch
from
+2,087 −383
Open

Add support for adding vestigial implicits #10156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
4357797
Add support for adding vestigial implicits
vaisest Aug 6, 2026
e9724d5
Prevent adding item to itself as vestigial
vaisest Aug 6, 2026
73f12be
Cleanup
vaisest Aug 6, 2026
fb25e63
Fix shavs + Infernal Mantle mod id
Aug 7, 2026
6bcec28
Fix equality comparison
vaisest Aug 6, 2026
9a44e25
Add "Core drop pool" filtering to vestigial implicits and unique db
vaisest Aug 7, 2026
c6228c9
Fix (hopefully) all the rest of the core drop pool uniques
vaisest Aug 7, 2026
b465ef4
Fix stasis prison and typo
vaisest Aug 7, 2026
1d87110
Regen modcache
vaisest Aug 7, 2026
f8466bb
Cleanup
vaisest Aug 7, 2026
d3f84c5
Remove delve implicits
vaisest Aug 9, 2026
2c140d0
Move popup code to its own module and remove various bits of dead code
vaisest Aug 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/Classes/ItemDBControl.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ function ItemDBClass:ItemDBControl(anchor, rect, itemsTab, db, dbType)
self.controls.requirement = new("DropDownControl"):DropDownControl({"LEFT",self.controls.sort,"BOTTOMLEFT"}, {0, 11, 179, 18}, { "Any requirements", "Current level", "Current attributes", "Current useable" }, function(index, value)
self.listBuildFlag = true
end)
self.controls.obtainable = new("DropDownControl"):DropDownControl({"LEFT",self.controls.requirement,"RIGHT"}, {2, 0, 179, 18}, { "Obtainable", "Any source", "Unobtainable", "Vendor Recipe", "Upgraded", "Boss Item", "Corruption"}, function(index, value)
self.controls.obtainable = new("DropDownControl"):DropDownControl({"LEFT",self.controls.requirement,"RIGHT"}, {2, 0, 179, 18}, { "Obtainable", "Any source", "Unobtainable", "Vendor Recipe", "Upgraded", "Boss Item", "Corruption", "Core Drop Pool"}, function(index, value)
self.listBuildFlag = true
end)
end
Expand Down Expand Up @@ -126,6 +126,8 @@ function ItemDBClass:DoesItemMatchFilters(item)
return false
elseif (self.controls.obtainable.selIndex == 7 and not (string.match(source, "Vaal Orb"))) then
return false
elseif (self.controls.obtainable.selIndex == 8) and item.source then
return false
end
end
if self.dbType == "UNIQUE" and self.controls.requirement.selIndex > 1 then
Expand Down
Loading
Loading