Skip to content

Fix some radius jewels mods not working correctly#2264

Merged
LocalIdentity merged 5 commits into
PathOfBuildingCommunity:devfrom
vaisest:fix-radius-ailments
Jun 26, 2026
Merged

Fix some radius jewels mods not working correctly#2264
LocalIdentity merged 5 commits into
PathOfBuildingCommunity:devfrom
vaisest:fix-radius-ailments

Conversation

@vaisest

@vaisest vaisest commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

Fixes #2260.

Description of the problem being solved:

It seems that radius jewels were only adding the first mod for each line. This meant that a mod such as ailment speed, which has one mod for each ailment type, only had the first mod applied. This fix is also applied for conquered radius jewels as they used the exactly same code

Steps taken to verify a working solution:

  • Ailment jewel tested
  • "Regular" time-lost jewels tested

Link to a build that showcases this PR:

See #2260

Before screenshot:

After screenshot:

image

@vaisest

vaisest commented Jun 21, 2026

Copy link
Copy Markdown
Contributor Author

I don't understand this modcache test. I regenerated it, but apparently the test's headless wrapper doesn't generate the very large radius line. No clue. Either way I don't see it being a real issue

@LocalIdentity LocalIdentity added the bug: behaviour Behavioral differences label Jun 26, 2026
@LocalIdentity LocalIdentity changed the title Fix radius jewels only applying the first mod in the list Fix some radius jewels mods not working correctly Jun 26, 2026
@LocalIdentity LocalIdentity merged commit 66d2ccb into PathOfBuildingCommunity:dev Jun 26, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug: behaviour Behavioral differences

Projects

None yet

Development

Successfully merging this pull request may close these issues.

time-lost jewel isn't calculating properly

2 participants