Skip to content

Add minion stats to sorting options for trade and tree#2261

Merged
LocalIdentity merged 8 commits into
PathOfBuildingCommunity:devfrom
vaisest:minion-stats
Jun 26, 2026
Merged

Add minion stats to sorting options for trade and tree#2261
LocalIdentity merged 8 commits into
PathOfBuildingCommunity:devfrom
vaisest:minion-stats

Conversation

@vaisest

@vaisest vaisest commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

Fixes #2257.

Description of the problem being solved:

This PR reworks power stat reporting across the program. This is done by combining minion and player dps, and separating minion stats.

For example, previously we preferred player stats. This was problematic because e.g. avg damage on the tree wouldn't take minions into account at all. Then we preferred minion stats. This is confusing when searching for ehp on the tree.

This PR sums minion and player dps together. This isn't highly relevant because according to Local there is exactly one skill that needs this, but I think it is logical. The rest of the stats are clearly separated between player and minion. That means that if you e.g. play minion pact and PoB doesn't dynamically calculate the dps, you can now search for Minion Life on the tree, while being able to search player EHP without changing skills.

With the trader, it's now possible to do both at the same time. I.e. you can search for DPS + player EHP + a tiny bit of minion EHP.

This should also centralises the fetching of a power value to one function: data.powerStatList.GetFromOutput(output, stat).

This also makes the stat weight panel bigger, because it had no reason to be so annoyingly tiny

Steps taken to verify a working solution:

Tested:

  • Trader
  • Item DB
  • Tree Power Report
  • Comparison Power Report
  • Anoint screen
  • Less is more stats (max taken hit)

Link to a build that showcases this PR:

Before screenshot:

image

After screenshot:

image

@vaisest vaisest marked this pull request as ready for review June 21, 2026 19:20
@vaisest vaisest marked this pull request as draft June 21, 2026 19:20
@vaisest vaisest marked this pull request as ready for review June 21, 2026 19:47
@vaisest vaisest added enhancement New feature, calculation, or mod pob1 Should also be merged into PoB1 Repo bug: behaviour Behavioral differences labels Jun 24, 2026
@LocalIdentity LocalIdentity merged commit a1d60e1 into PathOfBuildingCommunity:dev Jun 26, 2026
5 checks passed
@LocalIdentity LocalIdentity changed the title Rework power stats Add minion stats to sorting options for trade and tree Jun 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug: behaviour Behavioral differences enhancement New feature, calculation, or mod pob1 Should also be merged into PoB1 Repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Trade search feature returning really weak items.

2 participants