Skip to content

Fix explicit empty OIDC allowlist persistence - #5

Merged
chen21019 merged 1 commit into
mainfrom
verification/authentication-service-0.4.39
Sep 16, 2026
Merged

chen21019 merged 1 commit into
mainfrom
verification/authentication-service-0.4.39

Conversation

@chen21019

Copy link
Copy Markdown

Root cause

The policy path allowed an empty allowlist, but serialized the setting update through the generated Setting.Value field whose omitempty tag removed value from the HTTP payload. The platform therefore kept the prior restricted allowlist even after access mode became unrestricted. The existing fake platform decoded a missing field as the empty-string zero value, so the regression test could not distinguish omission from an explicit clear.

Fix

  • Send common setting updates as an explicit wire map so an empty value is preserved.
  • Make the policy test reject an update that omits the string value field.
  • Document the exact compatibility contract.
  • Bump reviewed release references to v0.4.39.

Verification

The branch security release gate builds and tests twice, compares deterministic packages, emits CycloneDX evidence, scans source, product, and build image, and blocks applicable Critical or High findings and secrets. After the immutable release, the integrated Authentik QA policy lifecycle will be rerun through the public Server API and database readback.

@chen21019
chen21019 requested a review from a team as a code owner September 16, 2026 13:32
@chen21019
chen21019 merged commit 3217b78 into main Sep 16, 2026
4 checks passed
@chen21019
chen21019 deleted the verification/authentication-service-0.4.39 branch September 16, 2026 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant