Fix explicit empty OIDC allowlist persistence - #5
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
The policy path allowed an empty allowlist, but serialized the setting update through the generated Setting.Value field whose omitempty tag removed value from the HTTP payload. The platform therefore kept the prior restricted allowlist even after access mode became unrestricted. The existing fake platform decoded a missing field as the empty-string zero value, so the regression test could not distinguish omission from an explicit clear.
Fix
Verification
The branch security release gate builds and tests twice, compares deterministic packages, emits CycloneDX evidence, scans source, product, and build image, and blocks applicable Critical or High findings and secrets. After the immutable release, the integrated Authentik QA policy lifecycle will be rerun through the public Server API and database readback.