Prevent isRefreshing from getting permanently stuck on fetch errors#2879
Open
Prevent isRefreshing from getting permanently stuck on fetch errors#2879
Conversation
Without try/finally, any exception thrown by the fetch function left isRefreshing=true forever, causing all subsequent refreshNow() calls to silently no-op — including the manual Refresh button. Also ensures firstLoad is always cleared so the spinner never shows indefinitely.
saratry
approved these changes
Mar 13, 2026
SzymonPobiega
approved these changes
Mar 13, 2026
5 tasks
johnsimons
approved these changes
Mar 16, 2026
Member
johnsimons
left a comment
There was a problem hiding this comment.
Good catch @dvdstelt.
Although this PR does not address #2883.
Both @PhilBastian and I got pinged by @ramonsmits on #2885 to review it.
We both looked at it and created a separate PR to address the bug.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes:
Without try/finally, any exception thrown by the fetch function left isRefreshing=true forever, causing all subsequent refreshNow() calls to silently no-op — including the manual Refresh button. Also ensures firstLoad is always cleared so the spinner never shows indefinitely.
Reviewer Checklist