Hide some aspects when using embedded mode #2761
Conversation
| >(<FAIcon class="footer-icon fake-link" :icon="faArrowTurnUp" /> <a :href="newVersions.newSCVersion.newscversionlink" target="_blank">v{{ newVersions.newSCVersion.newscversionnumber }} available</a>)</span | ||
| > | ||
| <template v-if="!isEmbedded"> | ||
| <span v-if="!newVersions.newSPVersion.newspversion && environment.sp_version"> ServicePulse v{{ environment.sp_version }} </span> |
There was a problem hiding this comment.
If may still be worthwhile to show the ServicePulse version, just not the version check.
There was a problem hiding this comment.
well, this is something we need to think about it, at the moment the versions are the same
There was a problem hiding this comment.
how are they the same? Wouldn't the SP version continue to be v2.x and SC v6.x?
There was a problem hiding this comment.
I was thinking more about this.
From a customer's perspective, once the 2 products become one (I feel like the Spice Girls!) I don't think it makes sense to display 2 different versions, for a customer that is irrelevant.
But I do understand that we may need a way to refer to it as part of support cases and so on.
So, given that in SC for the embedded version, we are in total control of the app.constants.js file and we have the new embedded flag, we could at the frontend, combine for example the SC version + the embedded flag to generate a version that is unique for that combo, example 1.0.0-embedded. As long as we can say that 1.0.0-embedded is SC v1 and SP v2.
Anyway, just a thought.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
PhilBastian
left a comment
PhilBastian
left a comment
There was a problem hiding this comment.
whoops, never posted my review comments
| >(<FAIcon class="footer-icon fake-link" :icon="faArrowTurnUp" /> <a :href="newVersions.newSCVersion.newscversionlink" target="_blank">v{{ newVersions.newSCVersion.newscversionnumber }} available</a>)</span | ||
| > | ||
| <template v-if="!isEmbedded"> | ||
| <span v-if="!newVersions.newSPVersion.newspversion && environment.sp_version"> ServicePulse v{{ environment.sp_version }} </span> |
There was a problem hiding this comment.
how are they the same? Wouldn't the SP version continue to be v2.x and SC v6.x?
Updated the UI to remove the need to show versions for ServiceControl and ServicePulse, when ServicePulse and ServiceControl are shipped together, so really a single version
Reviewer Checklist