Skip to content

Replace hardcoded config file names with constants in unit tests to fix teardown issue #5252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ramonsmits merged 1 commit into from
Jan 14, 2026
Merged

Replace hardcoded config file names with constants in unit tests to fix teardown issue #5252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/ServiceControl.Audit.UnitTests/PopulateAppSettingsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ namespace ServiceControl.UnitTests;
[TestFixture]
public class PopulateAppSettingsTests
{
const string ConfigFileName = "ServiceControl.Audit.exe.config";

[Test]
public async Task Should_populate_appSettings_from_exe_config_file()
{
Expand All @@ -24,7 +26,7 @@ public async Task Should_populate_appSettings_from_exe_config_file()
</configuration>
""";

await File.WriteAllTextAsync("ServiceControl.Audit.exe.config", config);
await File.WriteAllTextAsync(ConfigFileName, config);

var fileName = "ServiceControl.Audit";
if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
Expand Down Expand Up @@ -70,5 +72,5 @@ public async Task Should_populate_appSettings_from_exe_config_file()
}

[TearDown]
public void TearDown() => File.Delete("ServiceControl.exe.config");
public void TearDown() => File.Delete(ConfigFileName);
}
6 changes: 4 additions & 2 deletions src/ServiceControl.Monitoring.UnitTests/PopulateAppSettingsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ namespace ServiceControl.UnitTests;
[TestFixture]
public class PopulateAppSettingsTests
{
const string ConfigFileName = "ServiceControl.Monitoring.exe.config";

[Test]
public async Task Should_populate_appSettings_from_exe_config_file()
{
Expand All @@ -24,7 +26,7 @@ public async Task Should_populate_appSettings_from_exe_config_file()
</configuration>
""";

await File.WriteAllTextAsync("ServiceControl.Monitoring.exe.config", config);
await File.WriteAllTextAsync(ConfigFileName, config);

var fileName = "ServiceControl.Monitoring";
if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
Expand Down Expand Up @@ -74,5 +76,5 @@ public async Task Should_populate_appSettings_from_exe_config_file()
}

[TearDown]
public void TearDown() => File.Delete("ServiceControl.exe.config");
public void TearDown() => File.Delete(ConfigFileName);
}
6 changes: 4 additions & 2 deletions src/ServiceControl.UnitTests/PopulateAppSettingsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ namespace ServiceControl.UnitTests;
[TestFixture]
public class PopulateAppSettingsTests
{
const string ConfigFileName = "ServiceControl.exe.config";

[Test]
public async Task Should_populate_appSettings_from_exe_config_file()
{
Expand All @@ -24,7 +26,7 @@ public async Task Should_populate_appSettings_from_exe_config_file()
</configuration>
""";

await File.WriteAllTextAsync("ServiceControl.exe.config", config);
await File.WriteAllTextAsync(ConfigFileName, config);

var fileName = "ServiceControl";
if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
Expand Down Expand Up @@ -72,5 +74,5 @@ public async Task Should_populate_appSettings_from_exe_config_file()
}

[TearDown]
public void TearDown() => File.Delete("ServiceControl.exe.config");
public void TearDown() => File.Delete(ConfigFileName);
}