Skip to content

Bound captured ServiceControl stderr - #689

Closed
bob-particular-agent[bot] wants to merge 12 commits into
masterfrom
fix/bound-startup-diagnostics
Closed

bob-particular-agent[bot] wants to merge 12 commits into
masterfrom
fix/bound-startup-diagnostics

Conversation

@bob-particular-agent

Copy link
Copy Markdown

Targets report-platform-tool-startup-failure, the branch for #684.

ServiceControl’s stderr handler stays attached while the tool runs, so the captured output can grow for the lifetime of the sample. Keep the most recent 8,192 characters, including line endings, and trim oversized lines before appending them. Synchronize appends and snapshots so reading the startup diagnostic cannot race a background stderr callback.

The change is limited to AppLauncher and an internal BoundedOutput class.

Validation:

  • Release solution build and package generation pass with no warnings or errors.
  • All three existing active NUnit tests pass on macOS arm64 with clean data and an isolated .NET runtime. The explicit network test remains excluded.
  • Local checks exercised multiple error lines, an oversized line, and a real missing-runtime diagnostic. Regression test files are not included in this PR.

Base automatically changed from report-platform-tool-startup-failure to master October 26, 2026 16:10
@soujay

soujay commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

@soujay soujay closed this Oct 26, 2026
@soujay
soujay deleted the fix/bound-startup-diagnostics branch October 26, 2026 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants