Skip to content

Expose MaxDeliveryCount with a default set to 100#78

Merged
andreasohlund merged 6 commits intomainfrom
asb-630-alpha2
Apr 24, 2026
Merged

Expose MaxDeliveryCount with a default set to 100#78
andreasohlund merged 6 commits intomainfrom
asb-630-alpha2

Conversation

@andreasohlund
Copy link
Copy Markdown
Member

@andreasohlund andreasohlund commented Apr 23, 2026

  • Exposes the MaxDeliveryCount
  • Defaulting MaxDeliveryCount to 100 since functions have dlq autoforwarding enabled by default
  • Exposes ThrowOnMissingTopicWhenPublishing
  • updates to the latest asb transport 6.3
  • reuses logic to extract message id, headers and body to ensure transport and functions stay in sync

/// </summary>
/// <remarks>
/// <para>
/// This MaxDeliveryCount is set to <value>int.MaxValue</value> by default, to stay backward compatible. the
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this statement conflict with the preset 100 for Serverless mode?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, but I wonder if we have another issue.

@danielmarbach since the transport will only lower the default to 10 when the emulator is in use if a value isn't set we might need to bring that logic in here as well?

Or alternatively, always force the delivery count to 10 in the transport?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed with @danielmarbach, and we concluded that since the MaxDeliveryCount is now exposed, we can do nothing, and if users run in the emulator, they will get an exception and can then set it to 10 until MS fixes the issue with the emulator only supporting max 10

Alternatively, we could default to 10 (which is the default when using az, the portal, or the api), but that might be a bit too low? (ie if you do 10 immediate reties you would be dlq'd)

@andreasohlund andreasohlund merged commit e2c3d65 into main Apr 24, 2026
4 checks passed
@andreasohlund andreasohlund deleted the asb-630-alpha2 branch April 24, 2026 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants