fix: exit non-zero when tests fail - #35
Open
itskodama wants to merge 1 commit into
Open
Conversation
`test` counts failed tests, prints the total, and returns 0 regardless, so any CI step running it reports success no matter how many sources are broken. Sets `process.exitCode` rather than calling `process.exit()`, so the summary and the `--output` report both flush before the process ends.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem
testcounts failed tests and prints the total, then returns normally:There is no
process.exitorprocess.exitCodeanywhere in the command, so theprocess always ends with status
0.Failed: 4andFailed: 0look identical toanything downstream, which makes the command unusable as a CI gate.
The change