Fix loadChunksAsync ignoring ChunkStatus passed in - #14220
Merged
lynxplay merged 1 commit intoAug 29, 2026
Conversation
lynxplay
requested changes
Aug 29, 2026
lynxplay
left a comment
lynxplay
left a comment
Contributor
There was a problem hiding this comment.
This is the wrong patch to fix this in.
The chunk status param is introduced by moonrise, this diff needs to live in that patch as well.
github-project-automation
Bot
moved this from Awaiting review
to Changes required
in Paper PR Queue
Contributor
|
Beyond that, LGTM, moonrise correctly uses the param. |
HaHaWTH
force-pushed
the
fix/load-chunk-ignoring-chunkstatus
branch
from
August 29, 2026 11:18
22c6d74 to
4cb0a9e
Compare
Contributor
Author
I've moved the diff into the Moonrise optimization patch |
lynxplay
approved these changes
Aug 29, 2026
papermc-projects
Bot
moved this from Changes required
to Full approval
in Paper PR Queue
github-project-automation
Bot
moved this from Full approval
to Merged
in Paper PR Queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discovered this while implementing a feature in my fork that uses
moonrise$loadChunksAsyncwithChunkStatus.EMPTY.The method above didn't honor the chunk status I've passed in and always load chunks as
FULLlevel.This PR passes the requested chunk status to
scheduleChunkLoadinstead of the hard-codingChunkStatus.FULL.Currently Paper doesn't have callers that are passing levels lower than
FULL, so it looks more likely a future-proof fix.