Add SulfurCubeSwallowEvent#14061
Open
kacimiamine wants to merge 2 commits into
Open
Conversation
Strokkur424
approved these changes
Jul 13, 2026
Strokkur424
left a comment
Member
There was a problem hiding this comment.
I generally like the QoL this event provides. For anyone following along, with PlayerInteractAtEntityEvent, replacing the cube's contained item on interact can be done like so:
@EventHandler
void onInteractWithSulfurCube(PlayerInteractAtEntityEvent event) {
if (!(event.getRightClicked() instanceof SulfurCube cube)) {
return;
}
ItemStack is = event.getPlayer().getInventory().getItemInMainHand();
if (is.getType().asItemType() == ItemType.SHEARS) {
return;
}
if (!cube.getEquipment().getItem(EquipmentSlot.BODY).isEmpty()) {
return;
}
event.setCancelled(true);
cube.getEquipment().setItem(EquipmentSlot.BODY, ItemType.BIRCH_LOG.createItemStack());
event.getPlayer().swingMainHand();
}With this new event, that is simplified to just this:
@EventHandler
void onSulfurCubeSwallowItem(SulfurCubeSwallowItemEvent event) {
event.setNewItem(ItemType.BIRCH_LOG.createItemStack());
}Generally, a lot of entity interaction stuff is left just as a generic PlayerInteractAtEntityEvent. But in this case I'd argue there are enough lines saved and logical edge-cases (like that top version does not handle the small sulfur cubes not being allowed to swallow items normally) for this event to make sense.
The way it is integrated with NMS code also makes complete sense, for this reason I approve.
Author
|
The punctuation and comments should be all resolved now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new event to the sulfur cube swallowing an item after the player interaction.