Skip to content

Lazy initialization of formattedDisplayName #14039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dominilk01 wants to merge 1 commit into
base: main
Choose a base branch
from
+38 −0
Open

Lazy initialization of formattedDisplayName #14039

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions paper-server/patches/sources/net/minecraft/world/scores/Objective.java.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
--- a/net/minecraft/world/scores/Objective.java
+++ b/net/minecraft/world/scores/Objective.java
@@ -18,7 +_,7 @@
private final String name;
private final ObjectiveCriteria criteria;
private Component displayName;
- private Component formattedDisplayName;
+ private @Nullable Component formattedDisplayName; // Paper - Lazy initialization because only used internally by Commands
private ObjectiveCriteria.RenderType renderType;
private boolean displayAutoUpdate;
private @Nullable NumberFormat numberFormat;
@@ -36,7 +_,6 @@
this.name = name;
this.criteria = criteria;
this.displayName = displayName;
- this.formattedDisplayName = this.createFormattedDisplayName();
this.renderType = renderType;
this.displayAutoUpdate = displayAutoUpdate;
this.numberFormat = numberFormat;
@@ -81,12 +_,17 @@
}

public Component getFormattedDisplayName() {
+ // Paper start - Lazy initialization because only used internally by Commands
+ if (this.formattedDisplayName == null) {
+ this.formattedDisplayName = this.createFormattedDisplayName();
+ }
+ // Paper start - Lazy initialization because only used internally by Commands
return this.formattedDisplayName;
}

public void setDisplayName(final Component name) {
this.displayName = name;
- this.formattedDisplayName = this.createFormattedDisplayName();
+ this.formattedDisplayName = null; // Paper - Lazy initialization because only used internally by Commands
this.scoreboard.onObjectiveChanged(this);
}

Loading