Skip to content

Fix duplicate dispense events for some items - #13922

Open
Lulu13022002 wants to merge 6 commits into
PaperMC:mainfrom
Lulu13022002:fix/duplicate-dispense-events
Open

Lulu13022002 wants to merge 6 commits into
PaperMC:mainfrom
Lulu13022002:fix/duplicate-dispense-events

Conversation

@Lulu13022002

Copy link
Copy Markdown
Contributor

Replaces #8525

Both wither skulls and carved pumpkins fired a BlockDispenseEvent twice if they didn't spawn a mob.
This is possibly a behavior change, but as usual, it's actually a bug fix so the behavior before was wrong.

In general if the dispense action fails completely no event occur (i.e the item is not dispensed nor consumed), the event is only triggered for the action that will succeed (that is partially true currently but should be better now).
Also moved fluid pickup game event after the event for taking liquid in bucket since the event is cancellable.

@Lulu13022002
Lulu13022002 requested a review from a team as a code owner June 1, 2026 17:16
@github-project-automation github-project-automation Bot moved this to Awaiting review in Paper PR Queue Jun 1, 2026
Co-authored-by: Jake Potrebic <jake.m.potrebic@gmail.com>
@Lulu13022002
Lulu13022002 force-pushed the fix/duplicate-dispense-events branch from 77a7379 to afa36a2 Compare July 6, 2026 11:43
@lynxplay lynxplay added the publish-pr Enables a workflow to build Paperclip jars on the pull request. label Oct 22, 2026
@papermc-pr-publishing

papermc-pr-publishing Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Last updated for: 3cee6b51838dc6646b82f43bb7e652f2b2ec6981.

Download the Paperclip jar for this pull request: paper-13922.zip

Maven Publication

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven("https://maven-prs.papermc.io/Paper/pr13922") {
        name = "Maven for PR #13922" // https://github.com/PaperMC/Paper/pull/13922
        mavenContent {
            includeModule("io.papermc.paper", "dev-bundle")
            includeModule("io.papermc.paper", "paper-api")
        }
    }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

publish-pr Enables a workflow to build Paperclip jars on the pull request.

Projects

Status: Awaiting review

Development

Successfully merging this pull request may close these issues.

2 participants