Use internal block to item conversion for flower pots#13880
Open
MartijnMuijsers wants to merge 1 commit into
Open
Use internal block to item conversion for flower pots#13880MartijnMuijsers wants to merge 1 commit into
MartijnMuijsers wants to merge 1 commit into
Conversation
Before this change, the Bukkit ItemStack passed to the event is constructed from a Bukkit Material, which relies on the Bukkit mapping from blocks to items being the same as the Minecraft mapping from blocks to items. However, it is not the same. For example, new ItemStack(Material.POTATOES) does not give an ItemStack of type Material.POTATO as it should. So a flower pot block created as new FlowerPotBlock(Blocks.POTATOES, properties) will crash the server. After this change, the Bukkit ItemStack passed to the event is constructed from the Minecraft ItemStack, which relies on the Minecraft mapping from blocks to items being correct.
kennytv
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change, the Bukkit ItemStack passed to the event is constructed from a Bukkit Material, which relies on the Bukkit mapping from blocks to items being the same as the Minecraft mapping from blocks to items.
However, it is not the same.
For example, new ItemStack(Material.POTATOES) does not give an ItemStack of type Material.POTATO as this code would expect.
So a flower pot block created as new FlowerPotBlock(Blocks.POTATOES, properties) will crash the server.
After this change, the Bukkit ItemStack passed to the event is constructed from the Minecraft ItemStack, which has already been created based on the Minecraft mapping from blocks to items.