Optimize waypoint distance check#13857
Open
Foorcee wants to merge 2 commits into
Open
Conversation
yannicklamprecht
approved these changes
May 3, 2026
Uhuli
approved these changes
May 4, 2026
Owen1212055
approved these changes
May 10, 2026
| ); | ||
| - return source.distanceTo(receiver) >= broadcastRange; | ||
| + // Paper start - optimize waypoint distance check by using squared distance | ||
| + if (broadcastRange <= 0) return true; |
Contributor
There was a problem hiding this comment.
I don't think this check does anything, players are not added to the tracked list if their attribute is zero or less, same for the source.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The method
doesSourceIgnoreReceiveris called frequently, so using squared distance instead of calculating the actual distance is a straightforward improvement. Additionally, the distance check can be skipped when the broadcast range is set to zero.