Prevent ticking virtual world borders multiple times per server tick #13513
+15
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13511 by checking whether the world border in question has already been ticked during the current tick.
1.21.11 added some additional lerping logic into
WorldBorder.MovingBorderExtent#update(). Virtual (per-player) world borders are ticked byServerPlayer#tick(), meaning that each player viewing the world border ticks it. In <=1.21.10 this worked fine since there was no logic being done if the lerp was in progress, however, the added logic in .11 causes the server-side lerp speed to multiply based on the amount of players viewing the border.