Fix backward compat for World#setPVP #13503
Merged
+37
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lynxplay
approved these changes
Jan 4, 2026
Contributor
|
For documentation sake, this technically is a behaviour change over the pre-deprecated impl as the bool would not be persisted. This is now no longer the case but reliance on this is neither defined in the javadocs nor really useful im my eyes. |
Owen1212055
approved these changes
Jan 4, 2026
github-project-automation
bot
moved this from Awaiting review
to Merged
in Paper PR Queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current method will fail to apply the last operation in the following sequences (with the gamerule set to true initially):
setPVP(false) -> setPVP(true)