Skip to content

Conversation

@Vrganj
Copy link

@Vrganj Vrganj commented Jul 30, 2025

Adds mixPotion and canMixPotion methods to simulate what a brewing stand would do.
I think it's a fair change since there's really not much potion API currently.

@Vrganj Vrganj requested a review from a team as a code owner July 30, 2025 23:27
@github-project-automation github-project-automation bot moved this to Awaiting review in Paper PR Queue Jul 30, 2025
Copy link
Contributor

@lynxplay lynxplay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally a fan of the concept!
Some minor formatting and logic issues.

@github-project-automation github-project-automation bot moved this from Awaiting review to Changes required in Paper PR Queue Jul 30, 2025
@Lulu13022002
Copy link
Contributor

Seems you got tricked by parchment wrong param names for hasMix (mix doesn't do better really), potion is the ingredient and ingredient is the potion.

@Vrganj
Copy link
Author

Vrganj commented Jul 31, 2025

Looks like you're right. I kind of assumed potionItem referred to the same thing in either method. Thanks

Copy link
Contributor

@notTamion notTamion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really like how mixPotion returns the original itemstack when there is no mix available. I think we should either make this very clear in the jdocs or imo even better return null if the nms method returns the original itemstack

@Vrganj
Copy link
Author

Vrganj commented Aug 6, 2025

I don't really like how mixPotion returns the original itemstack when there is no mix available. I think we should either make this very clear in the jdocs or imo even better return null if the nms method returns the original itemstack

What if someone adds a noop potion mix? There's no way to differentiate between the two without also checking if the potion mix exists in the first place

@notTamion
Copy link
Contributor

What if someone adds a noop potion mix? There's no way to differentiate between the two

it will still return a copy of the result, not the exact original so a simple reference check should do (at least if i remember correctly from earlier, on my phone rn so can't double check)

@Vrganj Vrganj closed this Aug 7, 2025
@github-project-automation github-project-automation bot moved this from Changes required to Closed in Paper PR Queue Aug 7, 2025
@Vrganj Vrganj reopened this Jan 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Closed

Development

Successfully merging this pull request may close these issues.

5 participants