Skip to content

[Optimization] Deduplicate shared image/video utilities across VL processors#6988

Open
luukunn wants to merge 14 commits intoPaddlePaddle:developfrom
luukunn:merge_processor
Open

[Optimization] Deduplicate shared image/video utilities across VL processors#6988
luukunn wants to merge 14 commits intoPaddlePaddle:developfrom
luukunn:merge_processor

Conversation

@luukunn
Copy link
Collaborator

@luukunn luukunn commented Mar 24, 2026

Motivation

  • Extract shared image utility functions (smart_resize, round/ceil/floor_by_factor, is_scaled_image) into fastdeploy/input/image_processors/common.py, covering both qwen and paddleocr variants
  • Extract shared video utilities (VideoReaderWrapper, read_video_decord, sample_frames) into fastdeploy/input/video_utils.py, with separate sample_frames_qwen and sample_frames_paddleocr variants
  • Update all 4 VL image_processor.py files to import from the new shared modules instead of maintaining local copies
  • Update qwen_vl, qwen3_vl, paddleocr_vl processor files to use sample_frames from video_utils.py; remove now-empty qwen_vl_processor/process_video.py and paddleocr_vl_processor/process_video.py

💡 If this PR is a Cherry Pick, the PR title needs to follow the format by adding the [Cherry-Pick] label at the very beginning and appending the original PR ID at the end. For example, [Cherry-Pick][CI] Add check trigger and logic(#5191)

💡 如若此PR是Cherry Pick,PR标题需遵循格式,在最开始加上[Cherry-Pick]标签,以及最后面加上原PR ID,例如[Cherry-Pick][CI] Add check trigger and logic(#5191)

Modifications

Usage or Command

Accuracy Tests

Checklist

  • Add at least a tag in the PR title.
    • Tag list: [[FDConfig],[APIServer],[Engine], [Scheduler], [PD Disaggregation], [Executor], [Graph Optimization], [Speculative Decoding], [RL], [Models], [Quantization], [Loader], [OP], [KVCache], [DataProcessor], [BugFix], [Docs], [CI], [Optimization], [Feature], [Benchmark], [Others], [XPU], [HPU], [GCU], [DCU], [Iluvatar], [Metax]]
    • You can add new tags based on the PR content, but the semantics must be clear.
  • Format your code, run pre-commit before commit.
  • Add unit tests. Please write the reason in this PR if no unit tests.
  • Provide accuracy results.
  • If the current PR is submitting to the release branch, make sure the PR has been submitted to the develop branch, then cherry-pick it to the release branch with the [Cherry-Pick] PR tag.

Copilot AI review requested due to automatic review settings March 24, 2026 07:39
@paddle-bot
Copy link

paddle-bot bot commented Mar 24, 2026

Thanks for your contribution!

This comment was marked as resolved.

@codecov-commenter
Copy link

codecov-commenter commented Mar 24, 2026

Codecov Report

❌ Patch coverage is 82.52427% with 36 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (develop@aee293b). Learn more about missing BASE report.

Files with missing lines Patch % Lines
fastdeploy/input/video_utils.py 79.38% 20 Missing and 7 partials ⚠️
fastdeploy/input/image_processors/common.py 85.71% 5 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #6988   +/-   ##
==========================================
  Coverage           ?   73.28%           
==========================================
  Files              ?      399           
  Lines              ?    56041           
  Branches           ?     8842           
==========================================
  Hits               ?    41069           
  Misses             ?    12071           
  Partials           ?     2901           
Flag Coverage Δ
GPU 73.28% <82.52%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI review requested due to automatic review settings March 24, 2026 12:12

This comment was marked as resolved.

This comment was marked as resolved.

Copilot AI review requested due to automatic review settings March 24, 2026 17:24

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants