Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the context being passed to the Claude Code review contains only the PR details as well as the PR diff. In situation where the bot made a false positive finding and posted it to the PR, there is no mechanism for a human to appeal the finding. As a result the bot will continuously flag the same issue on subsequent reviews, and or keep requesting changes for the PR (see example).
This PR address that problem by adding a
review_contextto the review prompt. This review contexts contains:Ps. Wasn't sure that is the original intention of adding a thumb up and a thumb down in the add finding scripts (scripts/comment-pr-findings.js:57). My best guess is that the bot is trying to seed reaction UI for the user