fix: updated local properties configuration file#69
fix: updated local properties configuration file#69ramnar wants to merge 1 commit intoPSMRI:mainfrom
Conversation
📝 WalkthroughWalkthroughThe development environment configuration file has been updated to redirect API endpoints from production URLs to localhost-based development servers on specific ports, and API path versions have been simplified by removing version suffixes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
@drtechie - Please review this. admin api and common api in ECD Module seems to be having their own copy of the api . I see -v1 in the url. please check |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/environments/environment.local.ts`:
- Line 32: COMMON_API1 is set to a public loca.lt tunnel which will break the
three video-consultation endpoints (generateVideoLinkURL, sendSMSAPI,
updateCallStatusAPI); update COMMON_API1 to point to the local service (e.g.,
use the same localhost pattern as other local constants, such as
http://localhost:8081/) so those endpoints resolve to the local
video-consultation service, or if the service is intentionally not included in
this dev setup add a clear inline comment next to COMMON_API1 explaining that
omission and why the tunnel is left in place.
| const commonIP = 'http://localhost:8083/'; | ||
| const adminIP = 'http://localhost:8082/'; | ||
| const COMMON_API = `${commonIP}commonapi/`; | ||
| const COMMON_API1 = `https://commonurl.loca.lt/`; |
There was a problem hiding this comment.
COMMON_API1 still points to a public loca.lt tunnel — inconsistent with the rest of the local config.
Line 32 was not updated in this PR, but the three video-consultation endpoints that depend on it (lines 271–273) will silently fail if the tunnel https://commonurl.loca.lt/ is inactive:
generateVideoLinkURL → COMMON_API1 + video-consultation/generate-link
sendSMSAPI → COMMON_API1 + video-consultation/send-link
updateCallStatusAPI → COMMON_API1 + video-consultation/update-call-status
If a local video-consultation service is running (e.g., on port 8081), update the constant to match the localhost pattern used for the other services:
🔧 Proposed fix
-const COMMON_API1 = `https://commonurl.loca.lt/`;
+const COMMON_API1 = `http://localhost:8081/`; // adjust port as neededIf local video-consultation is intentionally excluded from this dev setup, a brief inline comment explaining why would prevent confusion.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@src/environments/environment.local.ts` at line 32, COMMON_API1 is set to a
public loca.lt tunnel which will break the three video-consultation endpoints
(generateVideoLinkURL, sendSMSAPI, updateCallStatusAPI); update COMMON_API1 to
point to the local service (e.g., use the same localhost pattern as other local
constants, such as http://localhost:8081/) so those endpoints resolve to the
local video-consultation service, or if the service is intentionally not
included in this dev setup add a clear inline comment next to COMMON_API1
explaining that omission and why the tunnel is left in place.
There was a problem hiding this comment.
@ramnar now that you are on it, can we remove this too?
There was a problem hiding this comment.
Seems like the humans are having a chat. I'll hop back into my burrow for now. If you need me again, just tag @coderabbitai in a new comment, and I'll come hopping out!
2 participants
📋 Description
JIRA ID:
Please provide a summary of the change and the motivation behind it. Include relevant context and details.
✅ Type of Change
ℹ️ Additional Information
Please describe how the changes were tested, and include any relevant screenshots, logs, or other information that provides additional context.
Summary by CodeRabbit