Skip to content

AMM-118: Expose account lock state in SearchEmployee4#123

Open
varundeepsaini wants to merge 1 commit intoPSMRI:mainfrom
varundeepsaini:AMM-118-time-based-account-lockout
Open

AMM-118: Expose account lock state in SearchEmployee4#123
varundeepsaini wants to merge 1 commit intoPSMRI:mainfrom
varundeepsaini:AMM-118-time-based-account-lockout

Conversation

@varundeepsaini
Copy link

@varundeepsaini varundeepsaini commented Mar 10, 2026

Part of PSMRI/AMRIT#118

Description

Extends m/SearchEmployee4 so Employee Master receives account lock state for every row when the list loads.

Changes

  • add failed-attempt lock metadata to the employee list response
  • include failedAttempt, lockTimestamp, and lockedDueToFailedAttempts
  • batch-load user lock metadata to avoid one query per listed user
  • keep admin deactivation separate from failed-attempt lock state

Why this shape was required

  • review comments on the UI PR required lock/unlock status to come from SearchEmployee4
  • the UI needs this data on initial load to render the correct Lock/Unlock control for each user

@coderabbitai
Copy link

coderabbitai bot commented Mar 10, 2026

Warning

Rate limit exceeded

@varundeepsaini has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 13 minutes and 47 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 1b0e8471-c0f0-456f-a4fb-afa7ef4a24f5

📥 Commits

Reviewing files that changed from the base of the PR and between 0683b41 and b827d62.

📒 Files selected for processing (4)
  • src/main/java/com/iemr/admin/data/employeemaster/M_User1.java
  • src/main/java/com/iemr/admin/data/employeemaster/V_Showuser.java
  • src/main/java/com/iemr/admin/repo/employeemaster/EmployeeMasterRepoo.java
  • src/main/java/com/iemr/admin/service/employeemaster/EmployeeMasterServiceImpl.java
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant