Repository navigation
Build with Java 21 and run Robolectric on Android 16 - #74
Merged
Merged
Conversation
Robolectric needs Java 21 for current Android SDKs, so every test was pinned to SDK 33 to suit the Java 17 toolchain. The toolchain, bytecode target and CI now use Java 21, and robolectric.properties runs all tests on SDK 36 (Android 17, the app's target, still breaks Compose input injection in androidx.test). The test JVM gets the java.io/jdk.internal.access access Robolectric needs on Java 17+, and a guard test checks the SDK. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every Robolectric test was pinned to
@Config(sdk = [33])because Robolectric needs Java 21 for current Android SDKs and the project was on Java 17.targetCompatibilityand KotlinjvmTarget21; CI uses Temurin 21app/src/test/resources/robolectric.propertiesruns all tests on SDK 36 (Android 16); the per-test SDK pins are gone--add-opens=java.base/java.io=ALL-UNNAMEDand--add-exports=java.base/jdk.internal.access=ALL-UNNAMED, which Robolectric needs on Java 17+RobolectricSdkTestguards the SDK levelWhy not SDK 37 (the app's target): the Compose UI tests fail there because androidx.test calls
InputManager.getInstance(), which Android 17 removed.Locally: 127 tests pass, lint has no errors, the release build succeeds, and a Java 21 debug build runs on a device.
🤖 Generated with Claude Code