Repository navigation
Stop crashing when a widget is removed from the home screen - #73
Merged
Merged
Conversation
Since the move to Glance, GlanceAppWidgetReceiver.onDeleted takes the broadcast's goAsync() itself, so DDWidgetProvider's own goAsync() returned null and finishing it crashed the app every time a widget was removed. The provider now leaves the broadcast to Glance and queues CleanupWidgetsWorker, which deletes the records of widgets no longer on the home screen. The startup cleanup was never run either: its one-off work shared the unique name of the periodic work, whose REPLACE policy cancelled it. It now has its own name. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
hameno
enabled auto-merge
October 10, 2026 19:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing a widget crashed the app on every 3.0 build (beta 3.0.0-198 included; production 2.1 is not affected):
GlanceAppWidgetReceiver.onDeletedalready takes the broadcast'sgoAsync(), so the provider's secondgoAsync()returned null. The provider now leaves the broadcast to Glance and queuesCleanupWidgetsWorker, which deletes the records of widgets no longer on the home screen.Also fixed: the startup cleanup never ran, because its one-off work shared the unique name of the periodic work, whose REPLACE policy cancelled it.
Verified on an emulator: removing a widget crashed the old build and doesn't crash the fixed one, and the cleanup runs. New Robolectric tests (with
androidx.work:work-testing) cover both cases.🤖 Generated with Claude Code