Skip to content

L23 — Route parameter name completion - #301

Open
shuvroroy wants to merge 4 commits into
PHPantom-dev:mainfrom
shuvroroy:feat/route-parameter-name-completion
Open

L23 — Route parameter name completion#301
shuvroroy wants to merge 4 commits into
PHPantom-dev:mainfrom
shuvroroy:feat/route-parameter-name-completion

Conversation

@shuvroroy

Copy link
Copy Markdown
Contributor

Implements L23. route('users.show', ['|' => 1]) now completes the
{parameters} of the named route's URI, which the scanner records from
the registration the name is declared on. Also in to_route(),
signedRoute(), and temporarySignedRoute().

Routes generated by Route::resource() are not covered — Laravel derives
their URIs from the resource name via Str::singular(). Filed as L40
rather than guessing at singular forms.

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, examples/)
  • I have updated the config schema (config-schema.json)
  • I have added/updated tests to cover my changes

@shuvroroy shuvroroy changed the title Route parameter name completion L23 — Route parameter name completion Jul 31, 2026
@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 93.84164% with 21 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/virtual_members/laravel/route_names.rs 90.59% 11 Missing ⚠️
src/completion/source/helpers.rs 91.42% 6 Missing ⚠️
src/virtual_members/laravel/helpers.rs 96.36% 2 Missing ⚠️
src/completion/handler/mod.rs 83.33% 1 Missing ⚠️
src/completion/laravel_route_params.rs 98.41% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants