Refactor: Replace System.out/err with pcgen.util.Logging to resolve PMD warnings - #7686
Refactor: Replace System.out/err with pcgen.util.Logging to resolve PMD warnings#7686cpstence wants to merge 1 commit into
Conversation
|
few comments: These were my findings, and here are from my bot:
I need you to leave suppresswarnings and don't touch this and/or you can analyze the Tips.java file, check where it is used, how and see, whether my bot's comment is applicable here. Regarding the ShowMessageDelegate -- this is serious, I agree with the bot: try to run integration tests (you can try this with the debugger, or change the code like "Vest was here and said: " + whatever is in the code and read the logs, whether your fix doesn't break anything. |
…MD warnings
@Vest