Skip to content

refactor: optimize value pool allocation in benchmarks #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TKorr merged 1 commit into from
Apr 28, 2026
+10 −7
Merged

refactor: optimize value pool allocation in benchmarks #121

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions benches/workloads.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,11 +56,14 @@ fn make_generator(workload: Workload) -> WorkloadGenerator {
.generator()
}

/// Pre-built `Arc<u64>` per key in `0..universe`. Sharing one pool across all
/// benchmark iterations keeps `Arc::new` out of the timed region so we measure
/// policy behavior rather than allocator latency.
fn build_value_pool(universe: u64) -> Arc<[Arc<u64>]> {
(0..universe).map(Arc::new).collect::<Vec<_>>().into()
/// Pre-allocate one `Arc<u64>` per key in the universe.
///
/// Reused across policies and workloads so the measured loop only pays the
/// cost of an `Arc::clone` (atomic refcount bump) per insert rather than a
/// fresh heap allocation. This isolates policy hit/miss/eviction behavior
/// from allocator variance.
fn preallocate_values() -> Vec<Arc<u64>> {
(0..UNIVERSE).map(Arc::new).collect()
}

// ============================================================================
Expand All @@ -70,7 +73,7 @@ fn build_value_pool(universe: u64) -> Arc<[Arc<u64>]> {
fn bench_hit_rates(c: &mut Criterion) {
let mut group = c.benchmark_group("hit_rate");
group.throughput(Throughput::Elements(OPS as u64));
let value_pool = build_value_pool(UNIVERSE);
let value_pool = preallocate_values();

for workload_case in STANDARD_WORKLOADS {
let workload = workload_case.workload;
Expand Down Expand Up @@ -181,7 +184,7 @@ fn bench_adaptation_speed(c: &mut Criterion) {

fn bench_comprehensive(c: &mut Criterion) {
let mut group = c.benchmark_group("comprehensive");
let value_pool = build_value_pool(UNIVERSE);
let value_pool = preallocate_values();

for workload_case in STANDARD_WORKLOADS {
let config = BenchmarkConfig {
Expand Down
Loading