Open
Conversation
noisyscanner
force-pushed
the
brad/ffi-exts
branch
3 times, most recently
from
409c7a1 to
9de6469
Compare
noisyscanner
force-pushed
the
brad/ffi-exts
branch
from
a2fc356 to
3058a98
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So that we can use TypeScript in FFI files. Currently we have to write JSDoc which is a nuisance, especially when we use TS elsewhere.
Since the
output/gets passed to a bundler anyway, it's ok if this dir contains TS - the Purs compiler simply copies it, no need for it to be concerned with TS transpilation itself.This PR is into the OA fork at the moment, but this may be possible to merge upstream. This solution is based off what Nate said on Discord. Wouldn't hold my breath for that though, it would be great if OA could use it in the meantime.