Added trace information - #36
Conversation
GavinMeredithBehr
left a comment
There was a problem hiding this comment.
Does the trace logging make any noticeable effect on PDF generation time? Or is it minimal overhead to include everywhere?
The code looks good, just took a little time to check as there seemed to be a bit of code refactoring as well as addition of tracing.
Final comment is, does it make sense to include the tracing in the NullLogger?
Nothing above blocks the review just curious on the above questions as I don't believe performance will be massively impacted I just wondered if we knew how noticeable it might be.
From my tests the impact is neglectable.
That is a question that I was also wondering if it makes sense to have this on the key methods, or if it makes sense to have in everything. |
Added tracing information to the code.
This information appears in the traces and enables show details 👁️