I updated the DocBox version to use the v5.0.2#346
Open
DavisVega1990 wants to merge 1 commit intodevelopmentfrom
Open
I updated the DocBox version to use the v5.0.2#346DavisVega1990 wants to merge 1 commit intodevelopmentfrom
DavisVega1990 wants to merge 1 commit intodevelopmentfrom
Conversation
Contributor
Author
|
bdw429s
requested changes
Mar 29, 2026
| } | ||
| ); | ||
| docbox = new docbox.DocBox() | ||
| .addStrategy( "HTML", { |
Collaborator
There was a problem hiding this comment.
@DavisVega1990 This is wrong. Why did you change the strategy? That's not the right one. The command docs needs to use the actual CommandBox strategy
|
|
||
| <!-- Zip API Docs --> | ||
| <zip destfile="${dist.dir}/${distro.name}-apidocs-${commandbox.version}.zip" basedir="${temp.dir}/apidocs"></zip> | ||
| <zip destfile="${dist.dir}/${distro.name}-apidocs-${commandbox.version}.zip" basedir="${temp.dir}/apidocs/CommandBox-CommandDocs"></zip> |
Collaborator
There was a problem hiding this comment.
Why did you change this directory?
| }, | ||
| "devDependencies":{ | ||
|
|
||
| "docbox":"https://github.com/Ortus-Solutions/DocBox/archive/v5.0.2.zip" |
Collaborator
There was a problem hiding this comment.
Please change this to use a proper Forgebox slug@vesrion. I'm not even sure why it was using a direct URL to start.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and which issue(s) is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Please note that all PRs must have tests attached to them
Type of change
Updated the DocBox version to use v5.0.2 to improve the UI and the SEO requirements
Please delete options that are not relevant.
Checklist