-
Notifications
You must be signed in to change notification settings - Fork 18
add github actions that checks if package-lock is not deleted #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| push: | ||
| branches: | ||
| - "**" # Run on push to any branch | ||
| pull_request: | ||
| branches: | ||
| - "**" # Run on PR to any branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will trigger twice for branches where we have a pull request open
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah good catch, i made them now run only on PR and when pushed to the main branch
|
The current check verifies that the file exists and it isn't empty. It won't catch invalid json or if the lock is out of sync with package json. What do you say we add something like this to encapsulate those checks too: |
Thanks for the recommendation, good call i implemented that as well |
add github actions that checks if package-lock is not deleted