-
Notifications
You must be signed in to change notification settings - Fork 18
chore: add agent rules file #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
||
| # Optional | ||
| DKG_BLOCKCHAIN=hardhat1:31337 # Network | ||
| DKG_OTNODE_URL=http://localhost:8900 # OT-node |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change comment to dkg-engine
| DKG_OTNODE_URL=http://localhost:8900 # OT-node | ||
| PORT=9200 # Server port | ||
| EXPO_PUBLIC_MCP_URL=http://localhost:9200 | ||
| EXPO_PUBLIC_APP_URL=http://localhost:8081 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is for dev environment, for prod it's also 9200
| ## Debugging Tips | ||
|
|
||
| 1. Check `apps/agent/dist/index.js` exists after build | ||
| 2. Test database: `rm *.db && npm run script:setup` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we instruct the agent that for debugging one of the first it does is delete the db?
|
Looks pretty good @Lexpeartha. A couple of ideas to improve (not all need to be included now, I'll try to sort them by priority):
|
| app = createExpressApp(); | ||
|
|
||
| plugin(mockDkgContext, mockMcpServer, express.Router()); | ||
| await connect(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't we need to mount the router for api tests below this line?
app.use("/", apiRouter);
|
I have a feeling that we are missing some code quality constraints. For example: Documentation Requirements
Testing Requirements
Performance Requirements
File Size Constraint
Build Size Limit (javascript)
Task Tracking (Required)
A task should always fit in one commit
Task Template# Task: [<tusk number ( last + 1 )>] <feature>
## Goal
- <short goal>
## Subtasks
- [ ] <subtask 1>
- [ ] <subtask 2>Build Completion Checklist (Required)
If Uncertain, Ask
|
Adds
AGENTS.mdat the project root to provide better context to coding agents