Skip to content

fix: add missing accessibility label and fix the hint label #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
nouha06 wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

fix: add missing accessibility label and fix the hint label #522

nouha06 wants to merge 8 commits into from

Conversation

@nouha06
Copy link
Member

@nouha06 nouha06 commented Dec 3, 2025 •
edited
Loading

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Description

Motivation & Context

Types of change

  • Bug fix (non-breaking which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Previews

Checklist

Contribution

Accessibility

  • My change follows accessibility good practices

Design

  • My change respects the design guidelines of Orange Unified Design System

Development

  • My change follows the developer guide
  • I have added unit tests to cover my changes (optional)

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • Manually test (dark mode, RTL, landscape display, tablet)
  • Documentation has been updated if relevant
  • Design review
  • A11y review
  • Internal files have been updated if relevant (THIRD_PARTY, NOTICE)
  • changelog.md has been updated respecting keep a changelog rules and referencing the issue

@nouha06 nouha06 requested a review from AhmedAmineZr December 3, 2025 15:22
@nouha06 nouha06 self-assigned this Dec 3, 2025
@nouha06 nouha06 linked an issue Dec 3, 2025 that may be closed by this pull request
[Bug][A11Y][Checkbox] Incorrect accessibility label #514
Open
1 task
@AhmedAmineZr AhmedAmineZr added 📖 documentation Improvements or additions to documentation 📱 demo app 🧰 library ⭐ v1.0 Tickets needed for mobile v1.0 release labels Dec 4, 2025
@AhmedAmineZr AhmedAmineZr added the TestFlight blocking iOS issue: TestFlight unavailable. We’ve created this label while we fix it label Dec 8, 2025
@AhmedAmineZr AhmedAmineZr added ⌛ waiting for validations and removed TestFlight blocking iOS issue: TestFlight unavailable. We’ve created this label while we fix it labels Dec 11, 2025
nouha06 and others added 4 commits December 16, 2025 15:20
@nouha06
Merge branch 'develop' into 514-buga11ycheckbox-incorrect-accessibili…
12504ac 
…ty-label

# Conflicts:
#	app/CHANGELOG.md
#	ouds_core/CHANGELOG.md
#	ouds_core/lib/components/checkbox/ouds_checkbox.dart
@nouha06
Merge branch 'develop' into 514-buga11ycheckbox-incorrect-accessibili…
162fb21 
…ty-label

# Conflicts:
#	app/CHANGELOG.md
#	ouds_core/CHANGELOG.md
@nouha06
fix : update changelog file
47a345a
@AhmedAmineZr
chore: update A11y checkbox
a87d11d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AhmedAmineZr AhmedAmineZr AhmedAmineZr approved these changes

Assignees

@nouha06 nouha06

Labels

📱 demo app 📖 documentation Improvements or additions to documentation 🧰 library 👌 OK Design 👌 OK PO ⭐ v1.0 Tickets needed for mobile v1.0 release ⌛ waiting for validations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug][A11Y][Checkbox] Incorrect accessibility label [Bug][A11Y] Checkbox: hint is missing on component

2 participants

@nouha06 @AhmedAmineZr