Skip to content

feat(component): Add loading state on select and text input #3278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
louismaximepiton wants to merge 18 commits into
base: ouds/main
Choose a base branch
from
Open

feat(component): Add loading state on select and text input #3278

louismaximepiton wants to merge 18 commits into from

Conversation

@louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Dec 16, 2025 •
edited by boosted-bot
Loading

Types of change

  • Non-breaking change
  • Breaking change (fix or feature that would change existing functionality and usage)

Related issues

Closes #3139

Context & Motivation

Add the loading state and examples for the loading state of select and text-input.

Description

NA

Checklists

  • I have read the contributing guidelines
  • My change follows the developer guide
  • My change pass all tests
  • My change is compatible with a responsive display
  • I have added tests (Javascript unit test or visual) to cover my changes
  • My change introduces changes to the documentation that I have updated accordingly
    • Title and DOM structure is correct
    • Links have been updated (title changes impact links)
    • CSS for the documentation
  • I have checked all states and combinations of the component with my change
  • I have checked all the impacts for the other components and core behavior (grid, reboot, utilities)

Checklist (for Core Team only)

  • The changes need to be in the migration guide
  • The changes are well displayed in Storybook (be careful if example order has changed for DSM)
  • The changes are compatible with RTL
  • Manually test browser compatibility with BrowserStack (Chrome 120, Firefox 121, Edge 120, Safari 15.6, iOS Safari, Chrome & Firefox on Android)

Progression (for Core Team only)

Live previews

@louismaximepiton louismaximepiton added 📖 documentation Improvements or additions to documentation css labels Dec 16, 2025
@boosted-bot boosted-bot moved this from In Progress / Draft to Need Dev Review in 🟣 [Orange-Boosted-Bootstrap] PRs Board Dec 16, 2025
@netlify
Copy link

netlify bot commented Dec 16, 2025 •
edited
Loading

✅ Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 9f98f10
🔍 Latest deploy log https://app.netlify.com/projects/boosted/deploys/694409b4da66ff00089929ee
😎 Deploy Preview https://deploy-preview-3278--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

MaxLardenois
MaxLardenois requested changes Dec 16, 2025
View reviewed changes
Copy link
Collaborator

@MaxLardenois MaxLardenois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👍

@boosted-bot boosted-bot moved this from Need Dev Review to Dev Review In Progress in 🟣 [Orange-Boosted-Bootstrap] PRs Board Dec 16, 2025
louismaximepiton and others added 2 commits December 17, 2025 10:39
@louismaximepiton @MaxLardenois
fix review
fe0e6b3 
Co-authored-by: Maxime Lardenois <maxime.lardenois@orange.com>
@louismaximepiton
fix after design input
23d38a9
@MaxLardenois MaxLardenois mentioned this pull request Dec 17, 2025
Open
2 tasks
Base automatically changed from ouds/main-lmp-add-select-input to ouds/main December 18, 2025 12:26
MaxLardenois
MaxLardenois approved these changes Dec 18, 2025
View reviewed changes
Copy link
Collaborator

@MaxLardenois MaxLardenois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@boosted-bot boosted-bot moved this from Dev Review In Progress to Need Lead Dev Review in 🟣 [Orange-Boosted-Bootstrap] PRs Board Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MaxLardenois MaxLardenois MaxLardenois approved these changes

Assignees

No one assigned

Labels

css 📖 documentation Improvements or additions to documentation

Projects

🟣 [Orange-Boosted-Bootstrap] PRs Board
Status: Need Lead Dev Review

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@louismaximepiton @MaxLardenois