Popup: Fix z-index in any case#161
Open
louismaximepiton wants to merge 2 commits intoOrange-OpenSource:mainfrom
Open
Popup: Fix z-index in any case#161louismaximepiton wants to merge 2 commits intoOrange-OpenSource:mainfrom
louismaximepiton wants to merge 2 commits intoOrange-OpenSource:mainfrom
Conversation
994a7ac to
03a086f
Compare
✅ Deploy Preview for iotmapcomponent ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There are two solutions to answer the #34 issue:
The first one is to remove
IOT-Map-Component/src/iotMapManager/src/iot-map-marker.ts
Line 53 in a2d92f1
This way seems more logical, but the following could happen:
The second one is to increase the
zindexOffsetof the same line to1000000as what was done inside the PR to avoid the case illustrated above.This looks to be mandatory because of this line on Markercluster side:
https://github.com/Leaflet/Leaflet.markercluster/blob/bd2794c35831612a86f63766c26d94f809de7abc/src/MarkerCluster.Spiderfier.js#L237
Maybe we can handle this in a different way but this seemed the more logical to me right now
How to test
Change
id: 's2'to get the following:Related issues
Fixes #34.