Draft
Conversation
Contributor
Author
Some notes for triage
|
Contributor
Author
|
This PR would need to be updated to reflect the new architecture. But the principle is probably still valid and relevant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18
FIxes #100
iotmapmanager-labsiotmapmanager-labsin the root projectiotmapmanager-labsin a real Orange Angular projectpeerDependencies(@types/leaflet,@types/leaflet.markercluster,leaflet-polylineoffsetandleaflet.markercluster)Bounds are not validissue comes fromangular.jsonand not inindex.htmlcomponent.tsWhat's been done regarding Node 16
We observed some issues while building the library with Node 14 so I embedded this modification as well in this PR:
npm iwith Node 16 insrc/iotMapManagerto updatepackage-lock.jsonnpm iwith Node 16 at the root of the project to updatepackage-lock.json.github/workflows/docs.ymlto use latest versions ofactions(v3) and use Node 16 (+ cache)How to test it locally / manually
npm iat the root of the projectsrc/iotMapmanagerand then runnpm inpm pack/tmpand runrm -rf iotmap* package ; cp /Users/ju/IOT-Map-Component/src/iotMapManager/iotmapmanager-2.6.8.tgz . ; tar -xvf iotmapmanager-2.6.8.tgz ; rm -rf /Users/ju/IOT-Map-Component/node_modules/iotmapmanager/* ; cp -R package/* /Users/ju/IOT-Map-Component/node_modules/iotmapmanager/npm run startHow to test it with the
iotmapmanager-labsTODO