SSASSF-2982: Fix token expiration rule#9
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses SSASSF-2982 by tightening API token timestamp validation so tokens with timestamps in the future don’t bypass the 10-minute expiration window.
Changes:
- Update token time tolerance check to disallow negative elapsed time (future-issued tokens relative to validator time).
- Add a test case asserting that tokens with future timestamps are invalid.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
test/api_token_test.rb |
Adds coverage for rejecting tokens that appear to be issued in the future. |
lib/secure_api/api_token/validation.rb |
Adjusts the time tolerance check used by ApiToken.valid? to handle future timestamps. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
… symmetric tolerance Use elapsed_time.abs so tokens from slightly-ahead servers (within the 10-minute clock-skew window) remain valid, while timestamps beyond the tolerance in either direction are rejected. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for:
https://jira.dentsplysirona.com/browse/SSASSF-2982 "Tokens with future timestamps ignore the token expiration 10 minute rule."