Skip to content

Refactor TransactionForm layout for better input organization#69

Merged
OrF8 merged 2 commits intomainfrom
moving-4-digits-input-section
Apr 9, 2026
Merged

Refactor TransactionForm layout for better input organization#69
OrF8 merged 2 commits intomainfrom
moving-4-digits-input-section

Conversation

@OrF8
Copy link
Copy Markdown
Owner

@OrF8 OrF8 commented Apr 9, 2026

This pull request updates the layout of the TransactionForm component to improve the placement of the "last 4 digits of card" input field for credit card transactions. The main change is moving this input outside the grid layout, so it always appears below the transaction type selection, making the form structure clearer and more consistent.

Form layout improvements:

  • Moved the "4 ספרות אחרונות של הכרטיס" (cardLast4) input field for credit card transactions out of the grid and placed it below the transaction type selection for better form organization. [1] [2]
  • Updated the name input field container to always span a single column, simplifying the grid logic.

@OrF8 OrF8 self-assigned this Apr 9, 2026
@OrF8 OrF8 added enhancement New feature or request javascript Pull requests that update javascript code labels Apr 9, 2026
Copilot AI review requested due to automatic review settings April 9, 2026 18:56
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the TransactionForm UI layout to make credit-card–specific inputs appear in a clearer, more consistent place within the form flow.

Changes:

  • Moved the credit card “last 4 digits” (cardLast4) input out of the grid so it renders below the transaction type selection.
  • Simplified the grid layout by removing the conditional column-span logic for the name field.
  • Repositioned the transaction type selector into the grid alongside the name field on sm+ breakpoints.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@OrF8 OrF8 merged commit f4e773f into main Apr 9, 2026
6 checks passed
@OrF8 OrF8 deleted the moving-4-digits-input-section branch April 9, 2026 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request javascript Pull requests that update javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants