build(deps): bump phpseclib/phpseclib from 3.0.56 to 4.0.1 - #923
Merged
Merged
Conversation
Bumps [phpseclib/phpseclib](https://github.com/phpseclib/phpseclib) from 3.0.56 to 4.0.1. - [Release notes](https://github.com/phpseclib/phpseclib/releases) - [Changelog](https://github.com/phpseclib/phpseclib/blob/master/CHANGELOG.md) - [Commits](phpseclib/phpseclib@3.0.56...4.0.1) --- updated-dependencies: - dependency-name: phpseclib/phpseclib dependency-version: 4.0.1 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
phpseclib 4 moved its namespace from phpseclib3\ to phpseclib4\, so the import no longer resolved and PHPStan reported RSA, its PrivateKey and ENCRYPTION_PKCS1 all unknown — six of eight checks failed on the bump alone. The API is unchanged: createKey(), loadPrivateKey(), withPadding() and ENCRYPTION_PKCS1 are all still there, verified against the installed package. Everything in CryptPKI resolves through the one import, so the change is that line in the two files that name the library, plus a comment that said 'phpseclib3' about behaviour that was never version-specific. CryptPKI decrypts the password the browser encrypts with JSEncrypt, so a silent change in padding or key handling would not fail a unit test — it would fail sign-in. Checked directly against the new library: a PKCS#1 v1.5 round trip through createKey -> loadPublicKey/encrypt -> loadPrivateKey/decrypt returns the plaintext.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps phpseclib/phpseclib from 3.0.56 to 4.0.1.
Release notes
Sourced from phpseclib/phpseclib's releases.
Changelog
Sourced from phpseclib/phpseclib's changelog.
Commits
bb7b959Merge branch '3.0' into 4.0d17e0ddCHANGELOG: add 3.0.57 release99b8775psalm fixes6b887bbMerge branch '4.0' of github.com:phpseclib/phpseclib into 4.0a8bac78Merge branch '3.0' into 4.03a43a75EC: implement blinding for montgomery curve multiplication6d4805fDH: add tests for all-zero shared secrets with Curve25519 / Curve44886669f0CHANGELOG: add 4.0.0 releasefb56bc5EC/Curve{25519,448} enhancements95082b6Merge branch '3.0' into 4.0Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)