use native http module instead of request dependency#6
Open
endel wants to merge 1 commit into
Open
Conversation
Author
|
BTW, I couldn't run the unit tests. I'd appreciate if you can validate if this change doesn't break anything 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've found redbird today, and was going to test it, but noticed that
redbirdhas too many dependencies. dolphin/request being one of them.This pull-request just removes
request, as it has 20 dependencies only for using GET + JSON parsing.See the dependency graph below:
And now, without
request: