Skip to content

use native http module instead of request dependency#6

Open
endel wants to merge 1 commit into
OptimalBits:masterfrom
endel:remove-request-dependency
Open

use native http module instead of request dependency#6
endel wants to merge 1 commit into
OptimalBits:masterfrom
endel:remove-request-dependency

Conversation

@endel

@endel endel commented Mar 29, 2019

Copy link
Copy Markdown

I've found redbird today, and was going to test it, but noticed that redbird has too many dependencies. dolphin/request being one of them.

This pull-request just removes request, as it has 20 dependencies only for using GET + JSON parsing.

See the dependency graph below:

Screenshot 2019-03-29 at 15 31 07

And now, without request:

Screenshot 2019-03-29 at 15 53 18

@endel

endel commented Mar 29, 2019

Copy link
Copy Markdown
Author

BTW, I couldn't run the unit tests. I'd appreciate if you can validate if this change doesn't break anything 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant