fix: dashboard esm-env runtime alias#416
Open
kaanyagci wants to merge 2 commits into
Open
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe production Dockerfile patches the standalone Nitro server with an ChangesRuntime patch
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
kaanyagci
force-pushed
the
agent/fix-dashboard-esm-env-runtime
branch
from
July 15, 2026 20:35
a66c2ef to
4e5b3d1
Compare
kaanyagci
marked this pull request as ready for review
July 15, 2026 20:41
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/start/Dockerfile`:
- Line 142: Update the inline Node validation command in the Dockerfile to also
require DEV === false, alongside the existing BROWSER and NODE checks. Use
node:assert with top-level await as appropriate so mismatches produce
informative assertion errors instead of only process.exit(1).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
esm-envpackage alias inside the self-hosted dashboard SSR bundle when pnpm emits onlyesm-env-runtimeimport("esm-env")resolves with the expected Node runtime flagsRoot cause
@number-flow/reactimportsesm-envat runtime. The workspace override resolves that dependency toesm-env-runtime, and the standalone Nitro output copies the target package directory into.output/server/node_moduleswithout preserving theesm-envalias. In the published self-hosted dashboard image this causes SSR routes using NumberFlow to fail withERR_MODULE_NOT_FOUND.Summary by CodeRabbit