support liege of the primordial damage buffs#996
Open
AIElemental wants to merge 1 commit intoOpenarl:devfrom
Open
support liege of the primordial damage buffs#996AIElemental wants to merge 1 commit intoOpenarl:devfrom
AIElemental wants to merge 1 commit intoOpenarl:devfrom
Conversation
|
@AIElemental I was excited to see your PR, since I've been wanting to plan out a Golemancer. I'm wondering is something got left out, though? When I tried this build, I was able to set the number of golems in the config. And the total number of golems did show up in the defensive calcs. But otherwise there was no change. |
|
Looks like it was mostly a mod caching issue. I did notice that this doesn't cover the minion damage, but what's here seems good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable 3.2 liege of the primordial "for each summoned golem" text.
Added to configs amount of summoned golems by type.
Damage buff and golem buff increase are calculated OK.
I could not make it so number of golems becomes zero if i disable skill. Like Lightning golem aura is disabled when you disable lightning golem skill.
number of golems is not checked against "number of active minions" stat