#843 Tooltip Text in multiple columns when longer than the screen height#960
Open
Wires77 wants to merge 308 commits intoOpenarl:devfrom
Wires77:issue-843
Open
#843 Tooltip Text in multiple columns when longer than the screen height#960Wires77 wants to merge 308 commits intoOpenarl:devfrom Wires77:issue-843
Wires77 wants to merge 308 commits intoOpenarl:devfrom
Wires77:issue-843
Conversation
Author
|
Added some changes to split the text only on new item slots now. In some cases it adds an extra column, but I think it's worth it for a more professional look (note that this image is at a minimum height setting):
|
Wires77
changed the title
Author
|
Looks like changing the draw layer for the shading broke the layering elsewhere. @Openarl can you add a getDrawLayer() method to the graphics API? Would simplify the change I have to make to fix it, but if not I'll have to brainstorm a few ways to fix this. EDIT: Fixed the issue with a draw stack for now. |
lucifering
added a commit
to lucifering/PathOfBuilding
that referenced
this pull request
Oct 4, 2019
来自：Openarl#960 ·现在装备界面中珠宝的提示框，可以同时显示插槽位置和珠宝属性了。 来自：Openarl#959 ·修复了传奇【不朽系命】国服翻译词缀用词变更造成的无法解析问题 ·修复了【裂风雷球】技能词缀描述中跳跃时间的错误 ·修复了【吟唱时施放(辅)】无法影响被触发的法术的问题 但是现在pob查看，被触发的法术将被2个吟唱时施放(辅)所辅助， 一个提供more加成，一个锁定了施法间隔。·
Bones of Ullr has no new variant. Also added support for its new type of mod ("+# to level of all <gem name> gems").
The wording on mods like "X for each <rarity> Item you have equipped" has been truncated to "X for each <rarity> Item Equipped". This would lead to Perandus Signet's respective mod not working correctly when importing a character opposed to a build. Hidden Potential was also using an outdated, albeit supported wording. Furthermore, this PR removes the old wordings that are no longer used anywhere. Reference: https://feathub.com/LocalIdentity/PathOfBuilding/+18
Fully implement impale DPS calculations Support for increased buff effect per golem and damage per golem Update uniques with changes 3.8 Add new 3.9 uniques and changes from teasers so far Added 100% increased crit chance from consecrated ground Add support for Triad Grips Add support for spell dodge boot enchant Add support for remaining fossil mods Cap shock effect at 50% Fix totem limits Fix elemental hit threshold gems again Fix double damage on heavy strike Fix minion resistance on raise spectre gem Fix bones of ullur mod Fix Perandus Signet mod Fix red nightmare block chance Trim image file sizes
Add sorting for DPS including Impale and average hit damage Add Impale DPS breakdown numbers Change Impale DPS display in sidebar to make it more clear Fix Primordial chain golem damage not working properly Fix withering touch not applying withered damage increases Fix Eternity shroud Elemental as Extra Chaos roll Fix crash related to Impale calculations for Shield charge and Spectral Shield Throw
Add Support for Greater Spell Echo Widen manage passives trees drop down box Rampage now appears as a box on the configs page Show Impale DPS in sidebar for minions Add The Ivory Tower Body armour (3.9 preview) Add Mistwall Buckler Shield (3.9 preview) Add support for Manastorms' lightning damage buff Add support for Arborix and its mods Add support for Augyre and its mods Add support for Vulconus and its mods Add support for new Coated Shrapnel mod Add support for Inquisitors increased damage on consecrated ground Sanctuary node Add support for Golem Commanders increased damage node Add increased area rampage mod support on Sinvicta's Mettle Add proper support for Champions' Master of Metal node (set the number of impales for this to work) Add Carion golem to list of golems that work with primordial harmony Add Bane of Legends node attack speed buff Add tooltip to Rage to list its effects Update Edge of Madness Fix Delve more bleed and poison damage mods to only apply to attacks and give more realistic damage numbers
Implements https://feathub.com/LocalIdentity/PathOfBuilding/+73 Also readded Dying Breath's old version which can still be obtained and is able to grant more block chance.
Add 3.9 Passive Tree Add 3.9 Unique Changes Add support for Ryslathas Coil Add support for Perquils Toe Add support for Vaal Arc Lucky Buff Add support for Chain of Command's mods Add support for Warcried recently Fix Minion DPS sorting bug for Uniques and tree Fix Toxic Rain/Rain of Arrows pierce bug Fix radius calcualtion for Jewels Fix Impale calculations for certain skills (Barrage, Blade Flurry, Blast Rain, Double Strike, Lacerate, Scourge Arrow, Cleave, Dual Strike, Riposte, Viper Strike, Static Strike) Counter attack skills now show proper damage for each hit instead of DPS when using Impale Update many uniques that had incorrect wordings Fix some files not having UTF-8 encoding
Add 3.9 Passive Tree Add 3.9 Unique Changes Add support for Ryslathas Coil Add support for Perquils Toe Add support for Vaal Arc Lucky Buff Add support for Chain of Command's mods Add support for Warcried recently Fix Minion DPS sorting bug for Uniques and tree Fix Toxic Rain/Rain of Arrows pierce bug Fix radius calcualtion for Jewels Fix Impale calculations for certain skills (Barrage, Blade Flurry, Blast Rain, Double Strike, Lacerate, Scourge Arrow, Cleave, Dual Strike, Riposte, Viper Strike, Static Strike) Counter attack skills now show proper damage for each hit instead of DPS when using Impale Update many uniques that had incorrect wordings Fix some files not having UTF-8 encoding
Add full search capability to all dropdown lists Items copied into PoB now retain their quality if above 20% Add support for Infernal Legion with Skitterbots Add support for shotgunning with Shattering Steel Add support for the timed buff granted by Chieftain's "Ngamahu, Flame's Advance" notable Add support for a mod on Chieftain's "Valako, Storm's Embrace" notable Add support for a mod on Chieftain's "Tasalio, Cleansing Water" notable Add support for a mod on Berserker's "War Bringer" notable Add support for a mod on Assassin's "Opportunistic" notable Add support for "per minion" modifiers on Necromancer's Bone Barrier notable Add Energy Shield to the sidebar for minion skills Add support for "Enemies Frozen by you take X% increased Damage" mod on Taryn's Shiver Add support for "if you've stopped taking Damage Over Time Recently" pantheon mod Add support for Fire DoT Multiplier on Awakened Burning Damage, Burning Arrow and Vaal Burning Arrow Add support for Shockwave Support's quality stats Add Pride to list of auras on Aul's Uprising Change resistance colours in the sidebar Update text on some uniques Fix Sporeguard Fungal Ground mod parsing Fix a bug where the source name of skills for ailments could be incorrect Fix chill calculations when using Elemental Focus Fix Rage Support and other sources of Rage not granting Movement Speed Fix "Socketed Skill Gems get a X% Mana Multiplier" modifier not working on skills which reserve mana Fix chance to deal Double Damage on Paradoxica and Frostbreath Fix default gem level for gems with a max level below 20 Fix Close Combat weapon checks Fix Sanctuary node not being able to be anointed Fix Nightblade weapon checks Fix Elusive mod persisting if the checkbox was ticked and the source to generate Elusive was taken away Fix incorrect calculations of Active Totem Limit Fix many configuration options that didn't work for minion granted effects Blade count for spectres' Blade Vortex Spectres' curses Ursa's Rallying Cry Holy Relic's Aura Lightning Golem's Aura Fix Ensnaring Arrow's damage debuff incorrectly stacking 3 times Fix incorrect calculation of auras and curses granted by minions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm hoping to make one more change to intelligently split the columns on equipping in different item slots, but this is a start. Here's an example for Brawn when you have 9 jewel sockets:
One remaining issue is that if the item has long enough mod lines (like watcher's eye) it might fall off the right side of the screen, even though the lines in the second (or third) column don't need all that space. This is because the width for all columns is calculated based on the longest line in any column, and I'm not positive it's worth trying to split that out into different column logic.