Fixed issue #846

[dragbone]

No description provided.

[Openarl]

Do NOT edit the skill data files directly; they are automatically generated by the data export system, a fact which is noted at the top of the files. The same goes for the item base and item modifier data files.

If you need to edit a skill, you have two choices:

1. Set up the data export system; I don't have time to walk you through this, but a few people managed to figure it out on their own, so perhaps you can too.
2. Make changes to the skill data files; then, once you've finished testing them, edit the skill file templates (Export\Skills\*.txt) so that the changes will be preserved during subsequent exports.

Additionally, as the inability to pierce is an intrinsic property of the projectile, and would never be granted from another source, it is more appropriate to use a skill property for this; so you'd put skill("cannotPierce", true) on the skill, then retrieve it from the skillData structure when doing the pierce calculations.

You also should be looking for other skills that share the same property, and flagging them as well. I know of at least one, Magma Orb, but there may be others.

[dragbone]

Thanks for taking the time to explain it, I'll have another look 😄

[dragbone]

I managed to setup the exporter and implemented your suggestion.
Two questions came up:

• What is your preference on committing the ModCache files? If I don't commit them then you'll have to recreate them before the release and if I do commit them then you'll have merge conflicts.
• Running the exporter changed many skills but I only included my changes here. The changes were mainly reordering of properties and also some new properties. Should I commit all changes/only my changes/never commit skill data files?